Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

priority expander: Documentation updates #2433

Merged
merged 3 commits into from
Oct 11, 2019
Merged

priority expander: Documentation updates #2433

merged 3 commits into from
Oct 11, 2019

Conversation

mgalgs
Copy link
Contributor

@mgalgs mgalgs commented Oct 9, 2019 •
edited
Loading

This contains a few updates to the priority expander docs:

  • Document random fallback behavior if no priority specs match.
  • Document group skipping behavior when group name doesn't match any priorities.
  • Use the kube-system namespace in the ConfigMap example.

@mgalgs
priority expander: Document random fallback
f671478 
When none of the regexes match in the priorities list,
CA will fall back to a random group selection.  Document
this in the readme.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2019
mgalgs added 2 commits October 9, 2019 13:59
@mgalgs
priority expander: Use kube-system namespace in example
2e0d1f0 
CA is most often deployed in the kube-system namespace.  Modify the
ConfigMap example accordingly.
@mgalgs
priority expander: Document skipping behavior for unmatched groups
0b7429a 
If a group doesn't match any of the regexes in the priorities list it won't
be considered for expansion, which could catch some users off-guard.
Document this behavior.
@mgalgs mgalgs changed the title priority expander: Document random fallback priority expander: Documentation updates Oct 9, 2019
@mgalgs
Copy link
Contributor Author

mgalgs commented Oct 9, 2019

/cc @piontec

@k8s-ci-robot
Copy link
Contributor

@mgalgs: GitHub didn't allow me to request PR reviews from the following users: piontec.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @piontec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Contributor

Jeffwan commented Oct 10, 2019

/cc @piontec

@k8s-ci-robot
Copy link
Contributor

@Jeffwan: GitHub didn't allow me to request PR reviews from the following users: piontec.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @piontec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

losipiuk
losipiuk approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6485f9c into kubernetes:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk approved these changes

@krzysztof-jastrzebski krzysztof-jastrzebski Awaiting requested review from krzysztof-jastrzebski

Assignees

@losipiuk losipiuk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgalgs @k8s-ci-robot @Jeffwan @losipiuk